Review PR #1342: stream the nightly export in parallel
Export accounts in parallel and stream the rowsOpen
The nightly order export got too slow for one thread and too big for memory. An assistant reworked it to stream rows and run accounts in parallel. Six defects ride along with the rework, and some untouched lines that look wrong are right.
AIOpened by the assistantnightly_export.py
Your task
Review PR #1342. Find the defects, place them on their lines, and rank them.
- read pr.diff, then file one entry in FINDINGS for each defect you find
- line is the line number in the NEW file, the numbers down the left of the diff
- severity is one of blocker, major, minor
- a finding filed against code this PR did not change is a false alarm
- the module docstring is the contract; check every changed line against it
At submit, your findings are matched against the planted defects by file and line.