AI-assisted engineering/Review the AI's PR

Review PR #2671: serve seat counts from Redis

Review the AI's PRHard45 min
Serve seat counts from Redis on the event pageOpen

During an on-sale, the event page reads the seat count about 4,000 times a second. An assistant put a Redis cache in front of that count. Five defects hide in the rework, and some untouched lines that look wrong are right.

AIOpened by the assistantseat_holds.py

Your task

Review PR #2671. Find the defects, place them on their lines, and rank them.

  • read pr.diff, then file one entry in FINDINGS for each defect you find
  • line is the line number in the NEW file, the numbers down the left of the diff
  • severity is one of blocker, major, minor
  • a finding filed against code this PR did not change is a false alarm
  • the module docstring is the contract; check every changed line against it

At submit, your findings are matched against the planted defects by file and line.