Code RoomFirst response never returns

MediumPrep Room Coding #1637

First response never returns

Code reviewCode quality & reviewMid–Senior~25 min

Review this Go fan-out worker that queries replicas and returns the first response.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 25 min

Mark a line and say what kind of problem it is.0 findings

1func firstReply(ctx context.Context, replicas []string) (string, error) {

2 results := make(chan string)

3 for _, addr := range replicas {

4 go func(a string) {

5 resp, err := query(ctx, a)

6 if err == nil {

7 results <- resp

8 }

9 }(addr)

10 }

11 select {

12 case r := <-results:

13 return r, nil

14 case <-ctx.Done():

15 return "", ctx.Err()

16 }

17}

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.