Context not cancelled on error
Review this Go helper that fetches with a per-call timeout.
What a strong answer looks like
Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.
0:00 of about 22 min
Mark a line and say what kind of problem it is.0 findings
1func fetch(url string) ([]byte, error) {
2 ctx, _ := context.WithTimeout(context.Background(), 2*time.Second)
3 req, _ := http.NewRequestWithContext(ctx, "GET", url, nil)
4 resp, err := http.DefaultClient.Do(req)
5 if err != nil {
6 return nil, err
7 }
8 return io.ReadAll(resp.Body)
9}
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.
Run or narrate your approach, then ask the coach.