Code reviewHardcr-g007

Subject Lock misuseLevel Senior–Staff~28 minCommon in Concurrency interviewsIndustries Software development

Question

Review this C++ thread-safe queue.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewcpp

1template <class T>2class Queue {3  std::mutex m_;4  std::deque<T> q_;5public:6  void push(T v) {7    m_.lock();8    q_.push_back(std::move(v));9    m_.unlock();10  }11  T pop() {12    m_.lock();13    T v = std::move(q_.front());14    q_.pop_front();15    return v;16  }17};

Run or narrate your approach, then ask the coach.