Code reviewMediumcr-g009

Subject Unclosed resourcesLevel Mid–Senior~24 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Java DAO method.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1public User findUser(long id) throws SQLException {2    Connection c = dataSource.getConnection();3    PreparedStatement ps = c.prepareStatement("SELECT * FROM users WHERE id = ?");4    ps.setLong(1, id);5    ResultSet rs = ps.executeQuery();6    if (rs.next()) {7        return mapUser(rs);8    }9    return null;10}

Run or narrate your approach, then ask the coach.