Resources not closed

Code reviewCode quality & reviewMid–Senior~24 min

Review this Java DAO method.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 24 min

Mark a line and say what kind of problem it is.0 findings

1public User findUser(long id) throws SQLException {

2 Connection c = dataSource.getConnection();

3 PreparedStatement ps = c.prepareStatement("SELECT * FROM users WHERE id = ?");

4 ps.setLong(1, id);

5 ResultSet rs = ps.executeQuery();

6 if (rs.next()) {

7 return mapUser(rs);

8 }

9 return null;

10}

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.