Code RoomTicker never stopped
MediumPrep Room Coding #1648

Ticker never stopped

Code reviewCode quality & reviewMid–Senior~22 min

Review this Go background poller started per request.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 22 min
Mark a line and say what kind of problem it is.0 findings
1func startPoller(report func(Stat)) {
2 ticker := time.NewTicker(time.Second)
3 go func() {
4 for {
5 <-ticker.C
6 report(collect())
7 }
8 }()
9}
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.