Code RoomSocket not closed on error
MediumPrep Room Coding #1650

Socket not closed on error

Code reviewNetworking & APIsMid–Senior~22 min

Review this Python TCP client.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 22 min
Mark a line and say what kind of problem it is.0 findings
1import socket
2 
3def send_ping(host, port, payload):
4 s = socket.create_connection((host, port), timeout=5)
5 s.sendall(payload)
6 resp = s.recv(1024)
7 s.close()
8 return resp
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.