Code Room
Code reviewHardcr-g015
Subject Lock misuseLevel Senior–Staff~26 minCommon in Concurrency interviewsIndustries Software development

Question

Review this Go rate limiter.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Talk through your review
Code to reviewgo
func (l *Limiter) Allow(key string) bool {	l.mu.Lock()	count := l.counts[key]	if count >= l.max {		return false	}	l.counts[key] = count + 1	l.mu.Unlock()	return true}
Run or narrate your approach, then ask the coach.