Code reviewHardcr-g018

Subject Concurrency bugsLevel Senior–Staff~26 minCommon in Concurrency interviewsIndustries Software development

Question

Review this Go batch runner.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewgo

1func runAll(jobs []Job) []Result {2	var wg sync.WaitGroup3	results := make([]Result, len(jobs))4	for i, j := range jobs {5		go func(i int, j Job) {6			wg.Add(1)7			defer wg.Done()8			results[i] = run(j)9		}(i, j)10	}11	wg.Wait()12	return results13}

Run or narrate your approach, then ask the coach.