Code reviewHardcr-g019

Subject AtomicityLevel Senior–Staff~26 minCommon in Concurrency · Algorithms & data structures interviewsIndustries Software development

Question

Review this Java memoizing cache built on ConcurrentHashMap.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1private final ConcurrentHashMap<Key, Value> cache = new ConcurrentHashMap<>();2 3public Value get(Key k) {4    if (cache.containsKey(k)) {5        return cache.get(k);6    }7    Value v = expensiveCompute(k);8    cache.put(k, v);9    return v;10}

Run or narrate your approach, then ask the coach.