Code reviewMediumcr-g037

Subject Weak randomnessLevel Mid–Senior~20 minCommon in Algorithms & data structures interviewsIndustries Software development

Question

Review this Node.js password-reset token generator.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjs

1function makeResetToken() {2  let t = '';3  const chars = 'abcdefghijklmnopqrstuvwxyz0123456789';4  for (let i = 0; i < 8; i++) {5    t += chars[Math.floor(Math.random() * chars.length)];6  }7  // store with 24h expiry8  return t;9}

Run or narrate your approach, then ask the coach.