Reset token uses weak randomness

Code reviewAlgorithms & data structuresMid–Senior~20 min

Review this Node.js password-reset token generator.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 20 min

Mark a line and say what kind of problem it is.0 findings

1function makeResetToken() {

2 let t = '';

3 const chars = 'abcdefghijklmnopqrstuvwxyz0123456789';

4 for (let i = 0; i < 8; i++) {

5 t += chars[Math.floor(Math.random() * chars.length)];

6 }

7 // store with 24h expiry

8 return t;

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.