Session ID randomness

Code reviewCode quality & reviewSenior–Staff~25 min

Review this Java session-id generator.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 25 min

Mark a line and say what kind of problem it is.0 findings

1import java.util.Random;

3public class SessionIds {

4 private static final Random RNG = new Random(System.currentTimeMillis());

6 public static String newSessionId() {

7 long id = RNG.nextLong();

8 return Long.toHexString(id);

9 }

10}

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.