Code Room
Code reviewHardcr-g038
Subject Weak randomnessLevel Senior–Staff~25 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Java session-id generator.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Talk through your review
Code to reviewjava
import java.util.Random; public class SessionIds {    private static final Random RNG = new Random(System.currentTimeMillis());     public static String newSessionId() {        long id = RNG.nextLong();        return Long.toHexString(id);    }}
Run or narrate your approach, then ask the coach.