Code reviewMediumcr-g044

Subject Integer overflowLevel Mid–Senior~20 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this C++ function that computes the average of a vector of 32-bit ints.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewcpp

1int average(const std::vector<int>& v) {2    int sum = 0;3    for (int x : v) {4        sum += x;5    }6    return sum / static_cast<int>(v.size());7}

Run or narrate your approach, then ask the coach.