Code reviewHardcr-g049

Subject Edge casesLevel Senior–Staff~25 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this C++ helper that returns the absolute value of a 32-bit int.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewcpp

1int32_t myAbs(int32_t x) {2    if (x < 0) {3        return -x;4    }5    return x;6}

Run or narrate your approach, then ask the coach.