Code reviewHardcr-g050

Subject CorrectnessLevel Senior–Staff~25 minCommon in Concurrency · Code quality & review interviewsIndustries Software development

Question

Review this Go code that fans out one goroutine per URL and collects results. (Assume Go 1.21.)

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewgo

1func fetchAll(urls []string) []string {2    var wg sync.WaitGroup3    results := make([]string, 0)4    for _, u := range urls {5        wg.Add(1)6        go func() {7            defer wg.Done()8            results = append(results, fetch(u))9        }()10    }11    wg.Wait()12    return results13}

Run or narrate your approach, then ask the coach.