Code Room
Code reviewMediumcr-g051
Subject Off by oneLevel Mid–Senior~20 minCommon in Databases & SQL · Algorithms & data structures interviewsIndustries Software development

Question

Review this Python function meant to return all length-k contiguous windows of a list.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Talk through your review
Code to reviewpython
def windows(xs, k):    out = []    for i in range(len(xs) - k):        out.append(xs[i:i + k])    return out
Run or narrate your approach, then ask the coach.