Code reviewMediumcr-g052

Subject Null handlingLevel Mid–Senior~20 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Go function that looks up a config value and returns it uppercased.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewgo

1func upperConfig(m map[string]*string, key string) string {2    v := m[key]3    return strings.ToUpper(*v)4}

Run or narrate your approach, then ask the coach.