Code reviewHardcr-g056

Subject Sign errorsLevel Senior–Staff~25 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Java method that maps an arbitrary hash to a bucket index in [0, n).

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1static int bucket(int hash, int n) {2    return hash % n;3}

Run or narrate your approach, then ask the coach.