Code reviewMediumcr-g058

Subject Null handlingLevel Mid–Senior~20 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this C++ function that returns the first element of a vector or a default.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewcpp

1int firstOr(const std::vector<int>& v, int dflt) {2    int first = v.front();3    if (v.empty()) {4        return dflt;5    }6    return first;7}

Run or narrate your approach, then ask the coach.