Order summary N+1 queries

Code reviewCode quality & reviewMid–Senior~25 min

Review this Python Django view.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 25 min

Mark a line and say what kind of problem it is.0 findings

1def order_summary(request):

2 orders = Order.objects.filter(status="paid")

3 rows = []

4 for order in orders:

5 rows.append({

6 "id": order.id,

7 "customer": order.customer.name, # FK lookup

8 "items": order.lineitem_set.count(), # reverse FK

9 "total": sum(li.price for li in order.lineitem_set.all()),

10 })

11 return JsonResponse({"rows": rows})

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.