Code reviewMediumcr-g067

Subject Inefficient data structureLevel Mid–Senior~20 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Python access-control filter.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewpython

1def load_blocklist(path):2    # ~100k banned user ids, one per line3    with open(path) as f:4        return [line.strip() for line in f]5 6def filter_allowed(events, path):7    blocklist = load_blocklist(path)8    allowed = []9    for ev in events:10        if ev.user_id not in blocklist:11            allowed.append(ev)12    return allowed

Run or narrate your approach, then ask the coach.