Code RoomBlocklist linear search
MediumPrep Room Coding #1703

Blocklist linear search

Code reviewCode quality & reviewMid–Senior~20 min

Review this Python access-control filter.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 20 min
Mark a line and say what kind of problem it is.0 findings
1def load_blocklist(path):
2 # ~100k banned user ids, one per line
3 with open(path) as f:
4 return [line.strip() for line in f]
5 
6def filter_allowed(events, path):
7 blocklist = load_blocklist(path)
8 allowed = []
9 for ev in events:
10 if ev.user_id not in blocklist:
11 allowed.append(ev)
12 return allowed
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.