Code reviewMediumcr-g069

Subject Missing cacheLevel Mid–Senior~25 minCommon in Code quality & review interviewsIndustries Software development, Technology

Question

Review this Java service method called on every request.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1public BigDecimal convert(BigDecimal amount, String from, String to) {2    List<Rate> rates = rateRepository.findAll();   // ~5000 rows, rarely changes3    BigDecimal fromRate = rates.stream()4        .filter(r -> r.getCurrency().equals(from)).findFirst().get().getValue();5    BigDecimal toRate = rates.stream()6        .filter(r -> r.getCurrency().equals(to)).findFirst().get().getValue();7    return amount.multiply(toRate).divide(fromRate, 8, RoundingMode.HALF_UP);8}

Run or narrate your approach, then ask the coach.