Enrich orders N+1 queries

Code reviewDatabases & SQLSenior–Staff~30 min

Review this Go function.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 30 min

Mark a line and say what kind of problem it is.0 findings

1func enrichOrders(ctx context.Context, db *sql.DB, orders []Order) ([]OrderView, error) {

2 views := make([]OrderView, 0, len(orders))

3 for _, o := range orders {

4 var name string

5 err := db.QueryRowContext(ctx,

6 "SELECT name FROM users WHERE id = $1", o.UserID).Scan(&name)

7 if err != nil {

8 return nil, err

9 }

10 views = append(views, OrderView{Order: o, UserName: name})

11 }

12 return views, nil

13}

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.