Apply discounts repeated config load

Code reviewCode quality & reviewMid–Senior~20 min

Review this Python pricing loop.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 20 min

Mark a line and say what kind of problem it is.0 findings

1def apply_discounts(items, config):

2 out = []

3 for item in items:

4 tax_rate = load_tax_config(config["region"])["rate"] # hits disk/cache

5 active = [r for r in config["rules"] if r["enabled"]]

6 discount = max((r["pct"] for r in active), default=0)

7 price = item.base * (1 - discount) * (1 + tax_rate)

8 out.append(price)

9 return out

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.