Prep Room
Sign inCreate account
Code Room
Code reviewMediumcr-g072
Subject Repeated workLevel Mid–Senior~20 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Python pricing loop.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts
Talk through your review
Code to reviewpython
def apply_discounts(items, config):    out = []    for item in items:        tax_rate = load_tax_config(config["region"])["rate"]   # hits disk/cache        active = [r for r in config["rules"] if r["enabled"]]        discount = max((r["pct"] for r in active), default=0)        price = item.base * (1 - discount) * (1 + tax_rate)        out.append(price)    return out
Run or narrate your approach, then ask the coach.