Code reviewMediumcr-g073

Subject Inefficient data structureLevel Mid–Senior~20 minCommon in Algorithms & data structures interviewsIndustries Software development

Question

Review this Java aggregation.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1public long sumReadings(SensorStore store) {2    List<Integer> data = new LinkedList<>();3    for (Reading r : store.fetchAll()) {4        data.add(r.getValue());   // ~1,000,000 readings5    }6    long sum = 0;7    for (int i = 0; i < data.size(); i++) {8        sum += data.get(i);9    }10    return sum;11}

Run or narrate your approach, then ask the coach.