Code reviewMediumcr-g074

Subject Missing cacheLevel Mid–Senior~20 minCommon in Algorithms & data structures interviewsIndustries Software development

Question

Review this JavaScript function used to size a dependency tree.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjavascript

1function countDeps(node, graph) {2  if (!graph[node] || graph[node].length === 0) return 1;3  let total = 1;4  for (const child of graph[node]) {5    total += countDeps(child, graph);6  }7  return total;8}

Run or narrate your approach, then ask the coach.