Extract IDs regex recompile

Code reviewCode quality & reviewMid–Senior~20 min

Review this Go log-parsing function.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 20 min

Mark a line and say what kind of problem it is.0 findings

1func extractIDs(lines []string) []string {

2 var ids []string

3 for _, line := range lines {

4 re := regexp.MustCompile(`req_id=([a-f0-9]{16})`)

5 m := re.FindStringSubmatch(line)

6 if m != nil {

7 ids = append(ids, m[1])

8 }

9 }

10 return ids

11}

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.