Code reviewHardcr-g079

Subject Repeated workLevel Senior–Staff~30 minCommon in Algorithms & data structures interviewsIndustries Software development

Question

Review this Java method that ranks products for each user.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1public List<Product> topForUser(User u, List<Product> products) {2    products.sort((a, b) -> {3        double sa = scorer.score(a, u);   // expensive ML scoring call4        double sb = scorer.score(b, u);5        return Double.compare(sb, sa);6    });7    return products.subList(0, Math.min(10, products.size()));8}

Run or narrate your approach, then ask the coach.