Top for user repeated scoring
Review this Java method that ranks products for each user.
What a strong answer looks like
Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.
0:00 of about 30 min
Mark a line and say what kind of problem it is.0 findings
1public List<Product> topForUser(User u, List<Product> products) {
2 products.sort((a, b) -> {
3 double sa = scorer.score(a, u); // expensive ML scoring call
4 double sb = scorer.score(b, u);
5 return Double.compare(sb, sa);
6 });
7 return products.subList(0, Math.min(10, products.size()));
8}
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.
Run or narrate your approach, then ask the coach.