Code reviewHardcr-g080

Subject Blocking ioLevel Senior–Staff~30 minCommon in Concurrency interviewsIndustries Software development

Question

Review this Python aggregator (using requests).

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewpython

1import requests2 3def fetch_balances(account_ids):4    # account_ids: list of independent account identifiers5    balances = {}6    for acct in account_ids:7        resp = requests.get(8            f"https://api.bank.com/v1/accounts/{acct}/balance",9            timeout=10,10        )11        balances[acct] = resp.json()["available"]12    return balances

Run or narrate your approach, then ask the coach.