Code reviewMediumcr-g081

Subject Missing cacheLevel Mid–Senior~25 minCommon in Storage & CDN · Networking & APIs interviewsIndustries Software development

Question

Review this Go HTTP handler serving a rarely-changing config blob.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewgo

1func configHandler(w http.ResponseWriter, r *http.Request) {2    cfg, err := loadConfigFromDB()   // ~50ms, changes a few times a day3    if err != nil {4        http.Error(w, "error", 500)5        return6    }7    b, _ := json.Marshal(cfg)8    w.Header().Set("Content-Type", "application/json")9    w.Write(b)10}

Run or narrate your approach, then ask the coach.