Config handler response time spikes

Code reviewStorage & CDNNetworking & APIsMid–Senior~25 min

Review this Go HTTP handler serving a rarely-changing config blob.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 25 min

Mark a line and say what kind of problem it is.0 findings

1func configHandler(w http.ResponseWriter, r *http.Request) {

2 cfg, err := loadConfigFromDB() // ~50ms, changes a few times a day

3 if err != nil {

4 http.Error(w, "error", 500)

5 return

6 }

7 b, _ := json.Marshal(cfg)

8 w.Header().Set("Content-Type", "application/json")

9 w.Write(b)

10}

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.