Code reviewHardcr-g085

Subject Blocking ioLevel Senior–Staff~30 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Go function that records each event.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewgo

1func recordEvent(dsn string, e Event) error {2    db, err := sql.Open("postgres", dsn)   // called on every event3    if err != nil {4        return err5    }6    defer db.Close()7    _, err = db.ExecContext(context.Background(),8        "INSERT INTO events(name, ts) VALUES($1, $2)", e.Name, e.Ts)9    return err10}

Run or narrate your approach, then ask the coach.