Code reviewHardcr-g096

Subject Timeout handlingLevel Senior–Staff~30 minCommon in Concurrency interviewsIndustries Software development

Question

Review this Python distributed-lock usage (Redis SETNX-style).

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewpython

1def process_job(job_id):2    lock = redis.set(f"lock:{job_id}", "1", nx=True)3    if not lock:4        return5    try:6        do_work(job_id)7    finally:8        redis.delete(f"lock:{job_id}")

Run or narrate your approach, then ask the coach.