Code reviewMediumcr-g103

Subject Swallowed exceptionsLevel Mid–Senior~20 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Java resource handler.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1public String readFirstLine(String path) {2    BufferedReader r = null;3    try {4        r = new BufferedReader(new FileReader(path));5        return r.readLine();6    } catch (IOException e) {7        log.warn("read failed");8        return null;9    } finally {10        try {11            if (r != null) r.close();12        } catch (IOException e) {13            return "";14        }15    }16}

Run or narrate your approach, then ask the coach.