File reader swallows close exception

Code reviewCode quality & reviewMid–Senior~20 min

Review this Java resource handler.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 20 min

Mark a line and say what kind of problem it is.0 findings

1public String readFirstLine(String path) {

2 BufferedReader r = null;

3 try {

4 r = new BufferedReader(new FileReader(path));

5 return r.readLine();

6 } catch (IOException e) {

7 log.warn("read failed");

8 return null;

9 } finally {

10 try {

11 if (r != null) r.close();

12 } catch (IOException e) {

13 return "";

14 }

15 }

16}

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.