Code reviewHardcr-g106

Subject Partial failureLevel Senior–Staff~30 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Go read-through cache.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewgo

1func GetUser(id string) (*User, error) {2	if u, ok := cache.Get(id); ok {3		return u.(*User), nil4	}5	u, err := db.LoadUser(id)6	if err != nil {7		return nil, err8	}9	cache.Set(id, u, 5*time.Minute)10	return u, nil11}

Run or narrate your approach, then ask the coach.