Cache miss on error

Code reviewCode quality & reviewSenior–Staff~30 min

Review this Go read-through cache.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 30 min

Mark a line and say what kind of problem it is.0 findings

1func GetUser(id string) (*User, error) {

2 if u, ok := cache.Get(id); ok {

3 return u.(*User), nil

4 }

5 u, err := db.LoadUser(id)

6 if err != nil {

7 return nil, err

8 }

9 cache.Set(id, u, 5*time.Minute)

10 return u, nil

11}

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.