Background task error unobserved

Code reviewConcurrencyCode quality & reviewMid–Senior~25 min

Review this JavaScript request handler doing background work.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 25 min

Mark a line and say what kind of problem it is.0 findings

1app.post("/import", (req, res) => {

2 res.status(202).json({ status: "accepted" });

3 processImport(req.body).then((r) => {

4 log.info("import done", r);

5 });

6});

8async function processImport(body) {

9 const rows = await parse(body);

10 await db.bulkInsert(rows);

11 return rows.length;

12}

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.