Code reviewMediumcr-g108

Subject Error handlingLevel Mid–Senior~25 minCommon in Concurrency · Code quality & review interviewsIndustries Software development

Question

Review this JavaScript request handler doing background work.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjs

1app.post("/import", (req, res) => {2  res.status(202).json({ status: "accepted" });3  processImport(req.body).then((r) => {4    log.info("import done", r);5  });6});7 8async function processImport(body) {9  const rows = await parse(body);10  await db.bulkInsert(rows);11  return rows.length;12}

Run or narrate your approach, then ask the coach.