Code RoomLocale-dependent number parsing

MediumPrep Room Coding #1752

Locale-dependent number parsing

Code reviewAlgorithms & data structuresMid–Senior~25 min

Review this Java code that parses a price string from a form post.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 25 min

Mark a line and say what kind of problem it is.0 findings

1import java.text.NumberFormat;

2

3double parsePrice(String s) throws Exception {

4 NumberFormat nf = NumberFormat.getInstance(); // default locale

5 return nf.parse(s).doubleValue();

6}

7

8// parsePrice("1.234") on a de-DE server

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.