Token lacks timestamp or signature

Code reviewCode quality & reviewMid–Senior~25 min

Review this Python code that puts a token in a URL.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 25 min

Mark a line and say what kind of problem it is.0 findings

1import base64, json

3def make_token(payload: dict) -> str:

4 raw = json.dumps(payload).encode('utf-8')

5 return base64.b64encode(raw).decode('ascii')

7def read_token(token: str) -> dict:

8 raw = base64.b64decode(token)

9 return json.loads(raw)

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.