Code reviewHardcr-g120

Subject Floating pointLevel Senior–Staff~30 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Java single-pass variance.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1double variance(double[] xs) {2    double sum = 0, sumSq = 0;3    for (double x : xs) { sum += x; sumSq += x * x; }4    int n = xs.length;5    double mean = sum / n;6    return sumSq / n - mean * mean;7}

Run or narrate your approach, then ask the coach.