Code reviewHardcr-g126

Subject LocaleLevel Senior–Staff~30 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Java that normalizes a protocol keyword before comparison.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1String normalize(String header) {2    return header.toUpperCase();   // compare against "CONTENT-TYPE", "TITLE", etc.3}4 5boolean isTitle(String h) {6    return normalize(h).equals("TITLE");7}

Run or narrate your approach, then ask the coach.