Code reviewMediumcr-g129

Subject EncodingLevel Mid–Senior~25 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Java that reads an uploaded text file's contents.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1import java.io.*;2 3String readAll(InputStream in) throws IOException {4    BufferedReader r = new BufferedReader(new InputStreamReader(in));5    StringBuilder sb = new StringBuilder();6    String line;7    while ((line = r.readLine()) != null) sb.append(line).append('\n');8    return sb.toString();9}

Run or narrate your approach, then ask the coach.