Error responses inconsistent
Review this Java Spring REST controller.
What a strong answer looks like
Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.
0:00 of about 22 min
Mark a line and say what kind of problem it is.0 findings
1@PostMapping("/orders")
2public ResponseEntity<?> create(@RequestBody OrderDto dto) {
3 if (dto.getItems().isEmpty()) {
4 return ResponseEntity.badRequest().body("items required");
5 }
6 try {
7 Order o = orderService.place(dto);
8 return ResponseEntity.ok(o);
9 } catch (Exception e) {
10 return ResponseEntity.status(500)
11 .body(e.getMessage());
12 }
13}
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.
Run or narrate your approach, then ask the coach.