Code reviewMediumcr-g137

Subject Leaky abstractionsLevel Mid–Senior~22 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this TypeScript API service method exposing an ORM entity.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewts

1// GET /teams/:id/members2async function getMembers(teamId: string) {3  const team = await Team.findByPk(teamId, { include: ['members'] });4  return team.members.map((m) => ({5    id: m.id,6    name: m.name,7    manager: m.getManager(),        // lazy association -> returns a Promise8    roleLabel: m.role.toUpperCase(),9  }));10}

Run or narrate your approach, then ask the coach.