Code reviewHardcr-g139

Subject Pagination bugsLevel Senior–Staff~25 minCommon in Networking & APIs interviewsIndustries Software development

Question

Review this Go cursor-pagination endpoint.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewgo

1func ListEvents(w http.ResponseWriter, r *http.Request) {2    after := r.URL.Query().Get("after") // last seen id3    limit := 504    rows, _ := db.Query(5        "SELECT id, ts, body FROM events WHERE id > $1 ORDER BY ts ASC LIMIT $2",6        after, limit)7    var out []Event8    for rows.Next() {9        var e Event10        rows.Scan(&e.ID, &e.TS, &e.Body)11        out = append(out, e)12    }13    next := ""14    if len(out) == limit {15        next = out[len(out)-1].ID16    }17    json.Marshal(out) // returns []; cursor lost18}

Run or narrate your approach, then ask the coach.