Error response format inconsistent
Review this TypeScript handler that proxies an upstream call.
What a strong answer looks like
Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.
0:00 of about 20 min
Mark a line and say what kind of problem it is.0 findings
1router.post('/send-sms', async (req, res) => {
2 try {
3 const result = await smsProvider.send(req.body.to, req.body.text);
4 res.json({ ok: true, sid: result.sid });
5 } catch (err) {
6 res.json({ ok: false, error: String(err) });
7 }
8});
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.
Run or narrate your approach, then ask the coach.