Breaking API changes in serializer

Code reviewCode quality & reviewMid–Senior~22 min

Review this TypeScript change to a v1 API serializer.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 22 min

Mark a line and say what kind of problem it is.0 findings

1// Existing v1 response consumed by many clients:

2// { "user_id": 42, "full_name": "Ada", "created": "2020-01-01" }

4function serializeUser(u: User) {

5 return {

6 userId: u.id, // renamed from user_id

7 fullName: u.name, // renamed from full_name

8 createdAt: u.createdAt.getTime(), // was ISO string, now epoch ms

9 };

10}

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.