Code reviewMediumcr-g145

Subject Backward compatibilityLevel Mid–Senior~22 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this TypeScript change to a v1 API serializer.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewts

1// Existing v1 response consumed by many clients:2// { "user_id": 42, "full_name": "Ada", "created": "2020-01-01" }3 4function serializeUser(u: User) {5  return {6    userId: u.id,                    // renamed from user_id7    fullName: u.name,                // renamed from full_name8    createdAt: u.createdAt.getTime(), // was ISO string, now epoch ms9  };10}

Run or narrate your approach, then ask the coach.