Code reviewMediumcr-g150

Subject Missing validationLevel Mid–Senior~22 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Java endpoint that ingests a batch of log events.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1@PostMapping("/ingest")2public ResponseEntity<Void> ingest(@RequestBody List<LogEvent> events) {3    for (LogEvent e : events) {4        Instant ts = Instant.parse(e.getTimestamp());5        store.write(e.getMessage(), ts);6    }7    return ResponseEntity.accepted().build();8}

Run or narrate your approach, then ask the coach.