Code reviewMediumcr-g155

Subject OwnershipLevel Mid–Senior~25 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Rust function that builds and reuses a connection config.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewrust

1struct Config { endpoints: Vec<String> }2 3fn dial(cfg: Config) -> std::io::Result<()> {4    // pretend this connects using the config5    Ok(())6}7 8fn run() -> std::io::Result<()> {9    let cfg = Config { endpoints: vec!["a:80".into(), "b:80".into()] };10    for attempt in 0..3 {11        println!("attempt {attempt}");12        dial(cfg)?;13    }14    Ok(())15}

Run or narrate your approach, then ask the coach.