Code reviewMediumcr-g156

Subject Buffer overflowLevel Mid–Senior~20 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this C string-copy helper.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewc

1#include <string.h>2#include <stdlib.h>3 4char *dup_upper(const char *src) {5    size_t len = strlen(src);6    char *out = malloc(len);          /* room for the chars */7    for (size_t i = 0; i < len; i++) {8        char c = src[i];9        out[i] = (c >= 'a' && c <= 'z') ? c - 32 : c;10    }11    out[len] = '\0';                  /* terminate */12    return out;13}

Run or narrate your approach, then ask the coach.