Code reviewHardcr-g158

Subject Iterator invalidationLevel Senior–Staff~30 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this C++ loop that prunes expired entries.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewcpp

1#include <map>2#include <cstdint>3 4void prune(std::map<int, uint64_t>& sessions, uint64_t now) {5    for (auto it = sessions.begin(); it != sessions.end(); ++it) {6        if (it->second < now) {7            sessions.erase(it);8        }9    }10}

Run or narrate your approach, then ask the coach.